I did a rebase on the latest master branch this morning, before I use
git-format-patch.


On Thu, Mar 27, 2014 at 1:01 PM, Timothy Chen (JIRA) <[email protected]>wrote:

>
>     [
> https://issues.apache.org/jira/browse/DRILL-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949858#comment-13949858]
>
> Timothy Chen commented on DRILL-449:
> ------------------------------------
>
> Your patch needs to be rebased from latest master as Jacques commited a
> bunch of things already.
>
> > The expression parser in Drill should throw exception and stop when it
> sees parsing error in expr
> >
> -------------------------------------------------------------------------------------------------
> >
> >                 Key: DRILL-449
> >                 URL: https://issues.apache.org/jira/browse/DRILL-449
> >             Project: Apache Drill
> >          Issue Type: Bug
> >            Reporter: Jinfeng Ni
> >            Assignee: Jinfeng Ni
> >         Attachments: DRILL-449.2.patch
> >
> >
> > Today, when the expression parser in Drill parses the expression in
> logical / physical plan, and sees a parsing error, it silently issue an
> warning, and continue the execution, and leading to an invalid or partially
> complete plan.  Such plan will eventually hit error during run-time
> execution phase.
> > In stead, the parser should stop the execution immediately and raise
> exception, when it sees a parsing error in the expression. This will help
> catch the error in an early stage, and make debugging the error an easier
> task.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)
>

Reply via email to