Github user amansinha100 commented on the pull request:
https://github.com/apache/incubator-drill/pull/49#issuecomment-40535783
One high-level comment regarding the code organization: normally, we
recommend keeping the operator's internal control flow and logic in the
template class (in this case HashJoinTemplate) and only put the stuff that code
generator needs in the 'batch' class. Perhaps we should discuss this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
