[ 
https://issues.apache.org/jira/browse/DRILL-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970068#comment-13970068
 ] 

ASF GitHub Bot commented on DRILL-505:
--------------------------------------

Github user amansinha100 commented on the pull request:

    https://github.com/apache/incubator-drill/pull/49#issuecomment-40535783
  
    One high-level comment regarding the code organization:  normally,  we 
recommend keeping the operator's internal control flow and logic in the 
template class (in this case HashJoinTemplate) and only put the stuff that code 
generator needs in the 'batch' class.  Perhaps we should discuss this ?  


> Implement hash join
> -------------------
>
>                 Key: DRILL-505
>                 URL: https://issues.apache.org/jira/browse/DRILL-505
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Mehant Baid
>            Assignee: Mehant Baid
>         Attachments: DRILL-505.patch
>
>
> Implement the hash join operator. The first version of the hash join 
> algorithm is a simple in memory implementation only and will not spill to 
> disk 
> Scope is to support inner, left outer, right outer and full outer joins for 
> simple equality conditions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to