----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20482/ -----------------------------------------------------------
Review request for drill, Jinfeng Ni and Mehant Baid. Repository: drill-git Description ------- Added the new codegen implementation for math functions for LOG, CBRT, RAND, PI on latest master. Diffs ----- exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2 exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5 exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION exec/java-exec/src/test/resources/functions/testNewMathFunctions.json PRE-CREATION Diff: https://reviews.apache.org/r/20482/diff/ Testing ------- Yes. mvn test -Dtest=TestNewMathFunctions#testNewMathFunc ----------------------------------------------- ACTUAL_RESULTS EXPECTED_RESULTS ----------------------------------------------- 2.302585092994046 2.302585092994046 10.0 10.0 3.141592653589793 3.141592653589793 ---------------------------------------------- Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.768 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 29.272 s [INFO] Finished at: 2014-04-18T19:04:01+05:30 [INFO] Final Memory: 53M/687M [INFO] ------------------------------------------------------------------------ Thanks, Yash Sharma
