----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20746/#review41571 -----------------------------------------------------------
Ship it! Ship It! - Aman Sinha On April 27, 2014, 7:29 a.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20746/ > ----------------------------------------------------------- > > (Updated April 27, 2014, 7:29 a.m.) > > > Review request for drill. > > > Bugs: DIRLL-578 > https://issues.apache.org/jira/browse/DIRLL-578 > > > Repository: drill-git > > > Description > ------- > > Fix performance issue in hash join, when the build side table contains large > number of duplicate keys. > Also iron out some NPE when the build / probe side batch is empty while > performing hash join. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java > 0718bff > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java > 7ada651 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinHelper.java > e0098b1 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbe.java > c99f2a6 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java > cc1a257 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoin.java > ba067e2 > exec/java-exec/src/test/resources/join/hj_exchanges.json PRE-CREATION > > Diff: https://reviews.apache.org/r/20746/diff/ > > > Testing > ------- > > Added test with exchanges > > > Thanks, > > Mehant Baid > >
