Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/incubator-drill/pull/56#discussion_r12080141
--- Diff: exec/java-exec/src/main/codegen/templates/AggrTypeFunctions3.java
---
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+<@pp.dropOutputFile />
+
+
+
+<#list aggrtypes2.aggrtypes as aggrtype>
+<#if aggrtype.className != "Avg">
--- End diff --
Instead of checking for exclusion of Avg, it would be better to have a
separate AggrThpyes3.tdd consisting of the new functions. The general idea was
that AggrTypes1 contains aggr functions that have 1 running workspace variable,
AggrType2 contains aggr functions that have 2 running workspace variables.
Since stddev, variance have 3 running workspace variables, why not put them in
their own tdd file ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
