DRILL-565: Remove spurious insertion into IdentityHashMap in 
ConstantExpressionIdentifier.visitFloatConstant()


Project: http://git-wip-us.apache.org/repos/asf/incubator-drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-drill/commit/ec3b8fc9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-drill/tree/ec3b8fc9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-drill/diff/ec3b8fc9

Branch: refs/heads/master
Commit: ec3b8fc992df8a2c742d2b424cfe4fea64083c24
Parents: 8109f17
Author: Aditya Kishore <[email protected]>
Authored: Thu Apr 24 02:13:30 2014 -0700
Committer: Jacques Nadeau <[email protected]>
Committed: Sat May 3 19:02:59 2014 -0700

----------------------------------------------------------------------
 .../apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-drill/blob/ec3b8fc9/exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java
----------------------------------------------------------------------
diff --git 
a/exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java
 
b/exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java
index 5cff001..c0c8484 100644
--- 
a/exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java
+++ 
b/exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java
@@ -124,7 +124,6 @@ public class ConstantExpressionIdentifier implements 
ExprVisitor<Boolean, Identi
 
   @Override
   public Boolean visitFloatConstant(ValueExpressions.FloatExpression fExpr, 
IdentityHashMap<LogicalExpression, Object> value) throws RuntimeException {
-    value.put(fExpr, true);
     return true;
   }
 

Reply via email to