----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20979/#review42211 -----------------------------------------------------------
exec/java-exec/src/main/codegen/data/DecimalAggrTypes1.tdd <https://reviews.apache.org/r/20979/#comment75974> What about sum? - Steven Phillips On May 4, 2014, 12:08 a.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20979/ > ----------------------------------------------------------- > > (Updated May 4, 2014, 12:08 a.m.) > > > Review request for drill. > > > Bugs: DRILL-619 > https://issues.apache.org/jira/browse/DRILL-619 > > > Repository: drill-git > > > Description > ------- > > Following functions are implemented > abs > ceil > floor > round > truncate > divide > modulo > > Following miscellaneous functions are also part of this patch > concat > length > to_char > to_number > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/util/DecimalUtility.java > 8255784 > exec/java-exec/src/main/codegen/config.fmpp 49e0614 > exec/java-exec/src/main/codegen/data/Casts.tdd 397dcdb > exec/java-exec/src/main/codegen/data/DecimalAggrTypes1.tdd PRE-CREATION > exec/java-exec/src/main/codegen/data/NumericTypes.tdd PRE-CREATION > exec/java-exec/src/main/codegen/templates/DateIntervalAggrFunctions1.java > PRE-CREATION > exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalFloat.java > 82f9a43 > exec/java-exec/src/main/codegen/templates/Decimal/DecimalFunctions.java > 4603853 > exec/java-exec/src/main/codegen/templates/DecimalAggrTypeFunctions1.java > PRE-CREATION > exec/java-exec/src/main/codegen/templates/FixedValueVectors.java cba9f97 > exec/java-exec/src/main/codegen/templates/NumericToCharFunctions.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java > 53c9952 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalAggFuncHolder.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalDivScaleFuncHolder.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalSetScaleFuncHolder.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalZeroScaleFuncHolder.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionConverter.java > 888829d > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java > 59be472 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java > aca5933 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java > f46f012 > > exec/java-exec/src/main/java/org/apache/drill/exec/resolver/ResolverTypePrecedence.java > f6d83e2 > > sqlparser/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java > PRE-CREATION > > sqlparser/src/test/java/org/apache/drill/jdbc/test/TestDateAggregateFunction.java > PRE-CREATION > sqlparser/src/test/java/org/apache/drill/jdbc/test/TestFunctionsQuery.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/20979/diff/ > > > Testing > ------- > > Added tests in TestFunctionsQuery. > > > Thanks, > > Mehant Baid > >
