My Bad!
On Wed, Jun 4, 2014 at 9:13 PM, Jacques Nadeau <[email protected]> wrote: > Sorry, I was saying Optiq's issue 247: > https://github.com/julianhyde/optiq/pull/247 > > It needs to be updated before it can be merged. > > > On Wed, Jun 4, 2014 at 8:33 AM, Yash Sharma <[email protected]> wrote: > > > Drill-247 is about the Math functions which is there in review board. Me > > and Mehant are having discussions on the same for closing it asap. > > > > > > On Wed, Jun 4, 2014 at 8:59 PM, Jacques Nadeau <[email protected]> > wrote: > > > > > While technically true, I think calling it a fork is a bit extreme. I > > > think we're a single commit off of a master commit (issue 247). The > only > > > issue is getting this incorporated and then upgrading Drill to the > latest > > > optiq. If someone wants to work on getting this done, that would be > > great. > > > In general, each Optiq upgrade has brought a number of required fixes > > and > > > query regression bugs as its apis are also changing pretty quickly > right > > > now so we have to be careful about stability and making sure we don't > see > > > functional or planning regressions. > > > > > > > > > > > > > > > On Wed, Jun 4, 2014 at 12:41 AM, Timothy Chen <[email protected]> > wrote: > > > > > > > We actually have Optiq as an external dependency, however the version > > > > we're using is not from the official Optiq repo but a private fork > > > > that was published to a private maven repo. > > > > > > > > This might have changed or already in progress being fixed, but just > > > > want to know the plan / timeline. > > > > > > > > Tim > > > > > > > > On Wed, Jun 4, 2014 at 12:32 AM, Renato Marroquín Mogrovejo > > > > <[email protected]> wrote: > > > > > I think having Optiq in the incubator now [1] will change the way > > this > > > is > > > > > going to be managed. But I think it is going to be better to have > it > > as > > > > an > > > > > external dependency now and not as a fork. > > > > > > > > > > > > > > > Renato M. > > > > > > > > > > [1] http://incubator.apache.org/projects/optiq > > > > > > > > > > > > > > > 2014-06-04 8:01 GMT+02:00 Timothy Chen <[email protected]>: > > > > > > > > > >> Hi Drillers, > > > > >> > > > > >> I'm wondering what's our plan for Optiq, as I believe we're still > on > > > > >> this Optiq fork (drill_wip) that we still rely upon. > > > > >> > > > > >> I'm hoping we can either rebase that branch on top of latest > master > > or > > > > >> get our changes in, as there are fixes in the latest optiq that > will > > > > >> be useful for us (ie: Window aggregations fixes). > > > > >> > > > > >> Do we have plans to do so? > > > > >> > > > > >> Tim > > > > >> > > > > > > > > > >
