----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22475/#review45685 -----------------------------------------------------------
Ship it! Ship It! - Mehant Baid On June 11, 2014, 9:29 p.m., Cliff Buchanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22475/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 9:29 p.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > * Modified getObject() for Date/Time/etc. SqlAccessors to convert underlying > joda.DateTime into java.sql.Date/Time/etc. > * Changed SqlAccessor template toString() to return the toObject().toString() > value. > - This is a preemptive change to be more JDBC compliant. > - near-future versions of sqlline may start calling getString() instead > of getObject(). > > > Diffs > ----- > > exec/java-exec/src/main/codegen/includes/vv_imports.ftl 114ecbe > exec/java-exec/src/main/codegen/templates/SqlAccessors.java b7207f9 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java > 93089e7 > > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java > 5c5a218 > > Diff: https://reviews.apache.org/r/22475/diff/ > > > Testing > ------- > > * Build with all junit tests except TestWithExchanges, > TestSimpleExternalSort, TestTpchDistributedMode, and TestTpchSingleMode. > * Ran disabled tests individually. > > > Thanks, > > Cliff Buchanan > >
