----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22241/#review46126 -----------------------------------------------------------
Ship it! - Parth Chandra On June 4, 2014, 5:59 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22241/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 5:59 p.m.) > > > Review request for drill and Parth Chandra. > > > Bugs: DRILL-898 > https://issues.apache.org/jira/browse/DRILL-898 > > > Repository: drill-git > > > Description > ------- > > Sign of nullable decimal data type are not set correctly and also we need to > get metadata of precision. > > Parent Diffs are DRILL-870, DRILL-748 and DRILL-875. > > > Diffs > ----- > > contrib/native/client/src/clientlib/decimalUtils.cpp 39439c5 > contrib/native/client/src/clientlib/recordBatch.cpp 066b898 > contrib/native/client/src/include/drill/drillc.hpp e5a0d33 > contrib/native/client/src/include/drill/recordBatch.hpp c40327b > > Diff: https://reviews.apache.org/r/22241/diff/ > > > Testing > ------- > > > Thanks, > > Xiao Meng > >
