----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22383/#review46232 -----------------------------------------------------------
Looks good except for the last issue mentioned underneath. Also, please correct the indentation in the template code before submitting the final patch. exec/java-exec/src/main/codegen/data/AggrBitwiseLogicalTypes.tdd <https://reviews.apache.org/r/22383/#comment81531> I believe that for Nullable input types, the output of bitwise operators should be Nullable as well. - Aditya Kishore On June 17, 2014, 9:59 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22383/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 9:59 p.m.) > > > Review request for drill, Aditya Kishore, Mehant Baid, and Timothy Chen. > > > Repository: drill-git > > > Description > ------- > > Bit wise and logical Aggregate functions. > > bit_and(expression) > bit_or(expression) > bool_and(expression) > bool_or(expression) > every(expression) > > > Diffs > ----- > > > common/src/main/java/org/apache/drill/common/expression/fn/CastFunctions.java > b76708d > exec/java-exec/src/main/codegen/config.fmpp 5c0d03b > exec/java-exec/src/main/codegen/data/AggrBitwiseLogicalTypes.tdd > PRE-CREATION > exec/java-exec/src/main/codegen/data/Casts.tdd e49df93 > > exec/java-exec/src/main/codegen/templates/AggrBitwiseLogicalTypeFunctions.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanAggrFunctions.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewAggregateFunctions.java > PRE-CREATION > exec/java-exec/src/test/resources/functions/test_logical_aggr.json > PRE-CREATION > exec/java-exec/src/test/resources/logical_aggr_input.json PRE-CREATION > > Diff: https://reviews.apache.org/r/22383/diff/ > > > Testing > ------- > > Yes. > > $ mvn test -Dtest=TestNewAggregateFunctions#testBitwiseAggrFuncs > > > Thanks, > > Yash Sharma > >
