----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22798/#review46319 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.hpp <https://reviews.apache.org/r/22798/#comment81642> Indentation seems off; can you replace tabs with spaces? Also, use cameCase for names (no underscores). contrib/native/client/src/clientlib/drillClientImpl.hpp <https://reviews.apache.org/r/22798/#comment81643> There are three places in the code where m_socket is closed. 1) The dtor (you've fixed this) 2) The deadline timer handler for handshake. We should add the shutdown call there are well. This might be related to the crash you see in the deadline timer? 3) The drillClientImpl::Close function. This is never used, but for completeness, we should add the shutdown call there. - Parth Chandra On June 20, 2014, 1:28 a.m., Norris Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22798/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 1:28 a.m.) > > > Review request for drill and Parth Chandra. > > > Bugs: DRILL-1045 > https://issues.apache.org/jira/browse/DRILL-1045 > > > Repository: drill-git > > > Description > ------- > > Properly shutting down the socket before closing it > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.hpp 0046b3e > > Diff: https://reviews.apache.org/r/22798/diff/ > > > Testing > ------- > > > Thanks, > > Norris Lee > >
