----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22846/#review46354 -----------------------------------------------------------
Ship it! Ship It! - Parth Chandra On June 20, 2014, 10:32 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22846/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 10:32 p.m.) > > > Review request for drill and Parth Chandra. > > > Bugs: DRILL-1052 > https://issues.apache.org/jira/browse/DRILL-1052 > > > Repository: drill-git > > > Description > ------- > > - updated generated C++ code to the latest protocol buffer protocol commit id > 2e07b0b8a > - update C++ client properly > > Changes in client implementation code: > > - `exec::user::QueryResult` chang to `exec::shared::QueryResult` > - `exec::user::QueryResult_QueryState_FAILED` moved to > `exec::shared::QueryResult_QueryState_FAILED` > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.hpp aa06556 > contrib/native/client/src/clientlib/drillClientImpl.cpp 0767396 > contrib/native/client/src/include/drill/protobuf/User.pb.h 982d34f > contrib/native/client/src/include/drill/recordBatch.hpp 9798997 > contrib/native/client/src/protobuf/BitControl.pb.h 8a7262b > contrib/native/client/src/protobuf/BitControl.pb.cc de6a9ca > contrib/native/client/src/protobuf/User.pb.cc a2bd4df > contrib/native/client/src/protobuf/UserBitShared.pb.h ece6b7b > contrib/native/client/src/protobuf/UserBitShared.pb.cc 154de54 > > Diff: https://reviews.apache.org/r/22846/diff/ > > > Testing > ------- > > > Thanks, > > Xiao Meng > >
