-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23154/
-----------------------------------------------------------
Review request for drill and Jacques Nadeau.
Bugs: DRILL-975
https://issues.apache.org/jira/browse/DRILL-975
Repository: drill-git
Description
-------
Currently if we encounter an exception within a function we will throw the
exception and fail the query. However it may be useful to introduce another
mode of execution where we use null when we encounter an exception in a
function but continue with the query execution.
Based on a a new session level parameter that can be set `exec.stop_on_error`
we switch between the two modes of execution (throw exception mode and use
nulls when exceptions are encountered)
Diffs
-----
exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLen.java aa216cd
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 7681dd5
exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java
be43d38
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
2e7a104
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillSimpleErrFuncNullableHolder.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionConverter.java
8328549
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
d7bc36b
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/GlobalFunctionRegistry.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/MethodGrabbingVisitor.java
3a87f43
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/ModifiedUnparseNullableVisitor.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java
2b4743d
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
eed0126
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
424d7ff
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlHandlerImpl.java
ee51f3b
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
f0c1ede
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/NonRootFragmentManager.java
51bf81c
exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java 741323b
exec/java-exec/src/test/java/org/apache/drill/exec/client/DumpCatTest.java
9090685
exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java
dd2c91e
exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestEvaluationVisitor.java
4d0cbcd
exec/java-exec/src/test/java/org/apache/drill/exec/expr/ExpressionTest.java
da82998
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestMathFunctions.java
104923b
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java
3289601
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestRepeatedFunction.java
4345560
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestCastFunctions.java
73b7b53
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestComparisonFunctions.java
172bbed
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestImplicitCastFunctions.java
ba3b646
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java
a686fa9
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java
b032c51
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestStringFunctions.java
af741a5
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestAgg.java
3669c5d
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/common/TestHashTable.java
e887584
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestSimpleFilter.java
1f87371
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoin.java
e24426e
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoin.java
4c1ce93
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java
0caf6d9
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/project/TestSimpleProjection.java
a05a632
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/sort/TestSimpleSort.java
6e9ecb1
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/TestSVRemover.java
6032681
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/trace/TestTraceMultiRecordBatch.java
abe3410
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/trace/TestTraceOutputDump.java
5817e0b
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/union/TestSimpleUnion.java
1fc2164
exec/java-exec/src/test/java/org/apache/drill/exec/record/ExpressionTreeMaterializerTest.java
d07ce85
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java
fbe037b
Diff: https://reviews.apache.org/r/23154/diff/
Testing
-------
Thanks,
Mehant Baid
