----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23103/#review47217 -----------------------------------------------------------
Ship it! Ship It! - Mehant Baid On June 27, 2014, 1:34 a.m., Cliff Buchanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23103/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 1:34 a.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > * Added date_trunc to DateDateArithmeticFunctions > * Do rounding with Joda > > > Diffs > ----- > > > exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateDateArithmeticFunctions.java > 676df67 > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java > ff45bb5 > exec/java-exec/src/test/resources/functions/date/date_trunc_arithmetic.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/23103/diff/ > > > Testing > ------- > > * Added tests (which may be timezone dependent) > * Tested w/ sqlline (to check that the right types were getting returned) > > > Thanks, > > Cliff Buchanan > >
