-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21371/
-----------------------------------------------------------
(Updated July 21, 2014, 10:56 p.m.)
Review request for drill.
Changes
-------
rebased master
Bugs: DRILL-705
https://issues.apache.org/jira/browse/DRILL-705
Repository: drill-git
Description
-------
Currently only supports partitioning/ordering, not yet preceding or after
offsets
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/expression/CastExpression.java
7e5eea0
common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java
edc1a53
common/src/main/java/org/apache/drill/common/expression/IfExpression.java
8dc220f
common/src/main/java/org/apache/drill/common/expression/NullExpression.java
f515d14
common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java
81457b5
common/src/main/java/org/apache/drill/common/expression/visitors/ConstantChecker.java
c73102a
common/src/main/java/org/apache/drill/common/logical/data/AbstractBuilder.java
69cb4eb
common/src/main/java/org/apache/drill/common/logical/data/AbstractSingleBuilder.java
e733fdd
common/src/main/java/org/apache/drill/common/logical/data/Limit.java 110204b
common/src/main/java/org/apache/drill/common/logical/data/LogicalOperatorBase.java
69a1c3c
common/src/main/java/org/apache/drill/common/logical/data/NamedExpression.java
4c006c6
common/src/main/java/org/apache/drill/common/logical/data/SingleInputOperator.java
0a5015c
common/src/main/java/org/apache/drill/common/logical/data/Window.java
PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/data/WindowFrame.java
0952406
common/src/main/java/org/apache/drill/common/logical/data/visitors/AbstractLogicalVisitor.java
8758444
common/src/main/java/org/apache/drill/common/logical/data/visitors/LogicalVisitor.java
4bf9fbf
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java
b9369ed
exec/java-exec/src/main/codegen/data/AggrTypes1.tdd d76d913
exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java aa9aeab
exec/java-exec/src/main/codegen/templates/TypeHelper.java 28cc428
exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java
c65951d
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java
5511cb2
exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java
cd08367
exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java
24d9cfe
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java
5e85425
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractSingle.java
6c0b98f
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperator.java
8f51390
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java
f0b0b9a
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Limit.java
0038e4e
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/LimitPOP.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/WindowPOP.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/InternalBatch.java
3e6def1
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
2f71bf9
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/filter/FilterRecordBatch.java
89a6d09
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitBatchCreator.java
ccbf755
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java
078c4c4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/producer/ProducerConsumerBatchCreator.java
0fcf4f3
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
985d96e
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/RemovingRecordBatch.java
42f2128
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/trace/TraceRecordBatch.java
b012cec
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFrameBatchCreator.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFrameRecordBatch.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFrameTemplate.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFramer.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillWindowRelBase.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java
3fc3b89
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillAggregateRel.java
fe5130c
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillLimitRule.java
c3b0d00
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjIntoScan.java
829eb14
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRel.java
7eca54e
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java
d0cd832
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRel.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitPrel.java
a4bb503
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
9ffbb06
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlAggOperator.java
299712e
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
cc779ad
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
b7d9bd7
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
2fcdef3
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java
e6f1fe1
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ExplainHandler.java
63db153
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java
17e80bd
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowSchemasHandler.java
5e77628
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java
a1c5aee
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java
5fa592a
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java
0170735
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java
3666b4c
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeTable.java
15da822
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java
1d94390
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowFiles.java
690e5fd
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowSchemas.java
faa69d1
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowTables.java
e66199a
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlUseSchema.java
76c7df3
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
721755d
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java
49c7399
exec/java-exec/src/main/java/org/apache/drill/exec/schema/Field.java 14049ef
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/NonRootFragmentManager.java
51bf81c
exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java e7c6dc0
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestUtils.java
PRE-CREATION
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java
0caf6d9
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
PRE-CREATION
exec/java-exec/src/test/resources/window/mediumData.json PRE-CREATION
exec/java-exec/src/test/resources/window/oneKeyCount.json PRE-CREATION
exec/java-exec/src/test/resources/window/oneKeyCountData.json PRE-CREATION
exec/java-exec/src/test/resources/window/oneKeyCountMultiBatch.json
PRE-CREATION
exec/java-exec/src/test/resources/window/twoKeys.json PRE-CREATION
exec/java-exec/src/test/resources/window/twoKeysData.json PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 61fca61
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java
39ba043
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java b681719
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java d5b2352
protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java
0c83e06
protocol/src/main/protobuf/UserBitShared.proto 10dce1f
tools/drill-patch-review.py c067ae2
Diff: https://reviews.apache.org/r/21371/diff/
Testing
-------
Thanks,
Timothy Chen
