----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24257/#review49827 -----------------------------------------------------------
Ship it! Ship It! exec/java-exec/src/main/codegen/templates/AbstractRecordWriter.java <https://reviews.apache.org/r/24257/#comment87197> Can you make the default behavior do a converter than does json conversion and then outputs as string. That way complex types work even in simple formats. exec/java-exec/src/main/codegen/templates/AbstractRecordWriter.java <https://reviews.apache.org/r/24257/#comment87198> Same as above. If a writer doesn't support a type, let's write as a string. exec/java-exec/src/main/codegen/templates/AbstractRecordWriter.java <https://reviews.apache.org/r/24257/#comment87199> Everywhere you have exceptions like this, can you use String.format() and add the name of the actual class implementation. E.g. MySpecialReader doesn't support writing... exec/java-exec/src/main/codegen/templates/JsonOutputRecordWriter.java <https://reviews.apache.org/r/24257/#comment87201> Should this be a freemarker switch statement? - Jacques Nadeau On Aug. 4, 2014, 8:14 p.m., Steven Phillips wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24257/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 8:14 p.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > The current parquet writer does not handle complex types. And there currently > is no json writer. > The goal is to enhance the record writer interface to handle complex types, > and implement this for parquet and json. The text writer will also handle > complex types, by printing out the JSON object when the field is complex. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/AbstractRecordWriter.java 6a7fb86 > exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java > b58f24c > exec/java-exec/src/main/codegen/templates/JsonOutputRecordWriter.java > PRE-CREATION > exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java > 5284199 > exec/java-exec/src/main/codegen/templates/RecordValueAccessor.java d4c6817 > exec/java-exec/src/main/codegen/templates/RecordWriter.java 2334a14 > exec/java-exec/src/main/codegen/templates/StringOutputRecordWriter.java > 9f0d701 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java > 29b346d > > exec/java-exec/src/main/java/org/apache/drill/exec/record/MaterializedField.java > a2d22cf > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java > 7fbb9c7 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java > a336316 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordWriter.java > 55f2b72 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java > cb77032 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java > 5350662 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java > 1cb0d06 > exec/java-exec/src/test/resources/donuts.json PRE-CREATION > protocol/src/main/java/org/apache/drill/common/types/MinorType.java 772e2ff > > Diff: https://reviews.apache.org/r/24257/diff/ > > > Testing > ------- > > > Thanks, > > Steven Phillips > >
