----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24470/#review50063 -----------------------------------------------------------
Shutdown has the unnecessary effect of closing down the connection and requiring the client application to reconnect. We need to test this out with BOOST_ASIO_DISBLE_IOCP defined to see if that might enable cancel to work for Win32. Otherwise, we need to retain the existing code and include the fix _ONLY_ for Windows 32-bit. I would use an appropriate ifdef something like WIN32_SHUTDOWN_ON_TIMEOUT and enable that only for Win32. - Parth Chandra On Aug. 7, 2014, 9:04 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24470/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 9:04 p.m.) > > > Review request for drill and Parth Chandra. > > > Bugs: DRILL-1219 > https://issues.apache.org/jira/browse/DRILL-1219 > > > Repository: drill-git > > > Description > ------- > > Socket cancel operation does not work for 32-bit windows platform. Use > shutdown insted. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.hpp 2bf7b5c > contrib/native/client/src/clientlib/drillClientImpl.cpp 6a29d88 > > Diff: https://reviews.apache.org/r/24470/diff/ > > > Testing > ------- > > > Thanks, > > Xiao Meng > >
