> On Aug. 19, 2014, 5:54 a.m., Parth Chandra wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java, > > line 125 > > <https://reviews.apache.org/r/24759/diff/1/?file=661968#file661968line125> > > > > Is the columnsFound array guaranteed to be initialized to false? If > > not, then we haven't initialized the array.
Yes, they are initialized to false in JAVA http://stackoverflow.com/a/12229524 - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24759/#review50957 ----------------------------------------------------------- On Aug. 16, 2014, 12:32 a.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24759/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2014, 12:32 a.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > Drill-982 Return null for non-existent columns in parquet reader > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java > 2228787 > > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java > 2193233 > > Diff: https://reviews.apache.org/r/24759/diff/ > > > Testing > ------- > > added new unit tests, ran full build on command line > > > Thanks, > > Jason Altekruse > >
