----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24758/#review51209 -----------------------------------------------------------
common/src/main/java/org/apache/drill/common/expression/PathSegment.java <https://reviews.apache.org/r/24758/#comment89306> Let's rename to contains exec/java-exec/src/main/codegen/templates/ListWriters.java <https://reviews.apache.org/r/24758/#comment89255> unused. pls delete. exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader2.java <https://reviews.apache.org/r/24758/#comment89256> we need handleAndRaise in case initial splitting fails. exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader2.java <https://reviews.apache.org/r/24758/#comment89257> let's remove guard statement here. exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader2.java <https://reviews.apache.org/r/24758/#comment89259> let's handleAndRaise here. exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java <https://reviews.apache.org/r/24758/#comment89305> Let's make sure columns have at least a value. exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java <https://reviews.apache.org/r/24758/#comment89278> Let's rename to contains. exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java <https://reviews.apache.org/r/24758/#comment89276> revise this. exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java <https://reviews.apache.org/r/24758/#comment89303> let's externalize the eat up logic here and consolidate to single loop - Hanifi Gunes On Aug. 16, 2014, 12:20 a.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24758/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2014, 12:20 a.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > Drill-1283 - JSON project pushdown > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/expression/PathSegment.java > 0ecfcd0 > common/src/main/java/org/apache/drill/common/expression/SchemaPath.java > 25ee8b4 > exec/java-exec/src/main/codegen/templates/BaseWriter.java e281bc7 > exec/java-exec/src/main/codegen/templates/ComplexWriters.java c390770 > exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 406d883 > exec/java-exec/src/main/codegen/templates/ListWriters.java 278fddc > exec/java-exec/src/main/codegen/templates/MapWriters.java 7aa5a2e > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java > 8b5577c > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader2.java > 3e2c81c > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java > e310b81 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java > 01fcfe0 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java > d365c6f > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReaderWithState.java > cf885a4 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/ComplexWriterImpl.java > 2fa72f7 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/VectorContainerWriter.java > 4f669c0 > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 5e52e82 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java > 89beeb0 > > exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java > 8b31958 > > exec/java-exec/src/test/resources/store/json/project_pushdown_json_physical_plan.json > PRE-CREATION > > exec/java-exec/src/test/resources/store/json/schema_change_int_to_string.json > PRE-CREATION > exec/java-exec/src/test/resources/store/json/single_column_long_file.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/24758/diff/ > > > Testing > ------- > > Added new unit tests, ran full build on command line > > > Thanks, > > Jason Altekruse > >
