----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25674/#review53464 -----------------------------------------------------------
Ship it! Looks good with minor nitpicking :) exec/java-exec/src/main/java/parquet/hadoop/CodecFactoryExposer.java <https://reviews.apache.org/r/25674/#comment93116> For brevity, please consider this. In the current form, some of the variable have larger scope than required. ```java if(DirectDecompressionCodec.class.isAssignableFrom(cx)) { DirectDecompressor decompr = ((DirectDecompressionCodec)c).createDirectDecompressor(); decompr.decompress(inpBuffer, outBuffer); ``` Also, is it possible to create the ```DirectDecompressor``` once and reuse it? - Aditya Kishore On Sept. 15, 2014, 4:10 p.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25674/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 4:10 p.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > DRILL-1368: NPE while reading from Gzip compressed Parquet file > > > Diffs > ----- > > exec/java-exec/src/main/java/parquet/hadoop/CodecFactoryExposer.java > d6584bb > > Diff: https://reviews.apache.org/r/25674/diff/ > > > Testing > ------- > > Tested with Gzip file on Mac (where Gzip decompression is not supported) and > checked the results. > > > Thanks, > > Parth Chandra > >
