> On Sept. 22, 2014, 1:05 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java, line 105 > > <https://reviews.apache.org/r/24778/diff/1/?file=662200#file662200line105> > > > > Same as above (sum0) > > Timothy Chen wrote: > This is actually needed for window function. Optiq automatically inserts > sum0 for the window version of sum, so I need to able to handle it. > > Jacques Nadeau wrote: > I understand it is needed. I believe it sum0 is already entirely added so > I would think that this change isn't needed. I believe sum0 is now a > separate template class.
Ok I'll remove this change. > On Sept. 22, 2014, 1:05 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestUtils.java, > > line 39 > > <https://reviews.apache.org/r/24778/diff/1/?file=662261#file662261line39> > > > > We're trying to deprecate SimpleRootExec. Is there a way you can > > similar tests using Jason's new testing validation framework? I don't > > really want to add new tests using SimpleRootExec. > > Timothy Chen wrote: > Where is Jason's new testing validation framework? > > Jacques Nadeau wrote: > I sent him an email on the list. If he doesn't give you something > shortly, skip it. I'm actually not evening using this new change anymore, TestWindowFrame.class is just using RemoteServiceSet. Removed this already in my last revision. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24778/#review54100 ----------------------------------------------------------- On Sept. 22, 2014, 6:27 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24778/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 6:27 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Bugs: DRILL-705 > https://issues.apache.org/jira/browse/DRILL-705 > > > Repository: drill-git > > > Description > ------- > > Currently only supports partitioning/ordering, not yet preceding or after > offsets > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/expression/CastExpression.java > b73a447 > > common/src/main/java/org/apache/drill/common/logical/data/AbstractBuilder.java > 427b040 > > common/src/main/java/org/apache/drill/common/logical/data/LogicalOperatorBase.java > 58a00fe > > common/src/main/java/org/apache/drill/common/logical/data/NamedExpression.java > 1550ddf > common/src/main/java/org/apache/drill/common/logical/data/Window.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/logical/data/WindowFrame.java > 6fb64bc > > common/src/main/java/org/apache/drill/common/logical/data/visitors/AbstractLogicalVisitor.java > d128b10 > > common/src/main/java/org/apache/drill/common/logical/data/visitors/LogicalVisitor.java > 4bf9fbf > exec/java-exec/src/main/codegen/data/AggrTypes1.tdd 812c289 > exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java e19def3 > exec/java-exec/src/main/codegen/templates/TypeHelper.java 9bb2507 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java > a5b7bee > exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java > d11f224 > exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java > 876ba37 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java > 48b3801 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractSingle.java > 2b10e6d > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperator.java > 8f51390 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java > 8da06cb > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/WindowPOP.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/InternalBatch.java > e690060 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java > ced5179 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/filter/FilterRecordBatch.java > f1fcce0 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java > f5bc9f9 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java > a1a8340 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/RemovingRecordBatch.java > 97f3608 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/trace/TraceRecordBatch.java > 6d90962 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/StreamingWindowFrameRecordBatch.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/StreamingWindowFrameTemplate.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/StreamingWindowFramer.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFrameBatchCreator.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillWindowRelBase.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java > 3fc3b89 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillAggregateRel.java > 6b0c3b4 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillLimitRule.java > c3b0d00 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjIntoScan.java > 082dacc > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRel.java > 7eca54e > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java > dbb85b2 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRel.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AggPrelBase.java > 05fb64a > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitPrel.java > 5060195 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/StreamingWindowPrel.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/StreamingWindowPrule.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java > 85a5734 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlAggOperator.java > 0b8668b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java > 2238155 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java > 708951a > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java > e63474f > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java > e6f1fe1 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ExplainHandler.java > f324321 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java > 3627a7b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowSchemasHandler.java > 5e77628 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java > a1c5aee > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java > 4005b81 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java > 10db4c4 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java > ccd08e1 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeTable.java > 29275d7 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java > 33b71b7 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowFiles.java > 8779969 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowSchemas.java > 9b42295 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowTables.java > 33d20aa > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlUseSchema.java > ed4695e > > exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java > 0adc09e > > exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java > e2f4a95 > exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java e7c6dc0 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java > 3ba6cb1 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestWindowFunctions.java > PRE-CREATION > exec/java-exec/src/test/resources/window/mediumData.json PRE-CREATION > exec/java-exec/src/test/resources/window/oneKeyCount.json PRE-CREATION > exec/java-exec/src/test/resources/window/oneKeyCountData.json PRE-CREATION > exec/java-exec/src/test/resources/window/oneKeyCountMultiBatch.json > PRE-CREATION > exec/java-exec/src/test/resources/window/twoKeys.json PRE-CREATION > exec/java-exec/src/test/resources/window/twoKeysData.json PRE-CREATION > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java > 0b5e6fc > protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java > d5b2352 > > protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java > 0c83e06 > protocol/src/main/protobuf/UserBitShared.proto 10dce1f > > Diff: https://reviews.apache.org/r/24778/diff/ > > > Testing > ------- > > Added few unit tests around window. > > > Thanks, > > Timothy Chen > >
