-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26088/#review54717
-----------------------------------------------------------



common/src/main/java/org/apache/drill/common/types/Types.java
<https://reviews.apache.org/r/26088/#comment95000>

    To be honest this isn't useful for my use case, as we don't make use of the 
LATE type in execution. I'll change it to throw an exception and anyone else 
that has a use for this utility method can re-assess if this is the right 
behavior for them.


- Jason Altekruse


On Sept. 26, 2014, 5:45 p.m., Jason Altekruse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26088/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 5:45 p.m.)
> 
> 
> Review request for drill and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> new unit test framework to ease the process of creating unit tests with full 
> result verification
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/drill/common/types/Types.java 8ae3edd 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/store/ClassPathFileSystem.java
>  5e00f08 
>   exec/java-exec/src/main/resources/bootstrap-storage-plugins.json 31df303 
>   exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 99c4da5 
>   exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java 
> PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java 
> 5768908 
>   exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/TestTestFramework.java 
> PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/TestValidationFramework.java 
> PRE-CREATION 
>   
> exec/java-exec/src/test/java/org/apache/drill/exec/HyperVectorValueIterator.java
>  PRE-CREATION 
>   
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
>  ac5673d 
>   exec/java-exec/src/test/resources/sort/testSelectWithLimitOffset.json 
> PRE-CREATION 
>   exec/java-exec/src/test/resources/sort/testSelectWithLimitOffset.tsv 
> PRE-CREATION 
>   
> exec/java-exec/src/test/resources/sort/testSelectWithLimitOffset_reordered.tsv
>  PRE-CREATION 
>   pom.xml 3cc4f38 
> 
> Diff: https://reviews.apache.org/r/26088/diff/
> 
> 
> Testing
> -------
> 
> Added both positive an negative unit test for varioud functionalities in the 
> unit test framework. All previous unit tests are passing.
> 
> 
> Thanks,
> 
> Jason Altekruse
> 
>

Reply via email to