> On Sept. 26, 2014, 2:07 p.m., Steven Phillips wrote: > >
Thanks for reviewing! > On Sept. 26, 2014, 2:07 p.m., Steven Phillips wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ProfileResources.java, > > line 156 > > <https://reviews.apache.org/r/26087/diff/1/?file=706157#file706157line156> > > > > How will this work in the case that there are profiles in pStore from > > before this change was made? Nice catch. I'll fix this in the next patch. > On Sept. 26, 2014, 2:07 p.m., Steven Phillips wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkPStoreProvider.java, > > line 39 > > <https://reviews.apache.org/r/26087/diff/1/?file=706162#file706162line39> > > > > This option should be added either to drill-override.conf, or > > drill-override-example.conf which are included in binary distribution. Will add an example setting to "drill-override-example.conf" in the next patch. - Aditya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26087/#review54725 ----------------------------------------------------------- On Sept. 26, 2014, 9:51 a.m., Aditya Kishore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26087/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2014, 9:51 a.m.) > > > Review request for drill. > > > Bugs: DRILL-1414 > https://issues.apache.org/jira/browse/DRILL-1414 > > > Repository: drill-git > > > Description > ------- > > This is the first draft of the changes done for this feature. It implements > the first approach described on the feature JIRA > (https://issues.apache.org/jira/browse/DRILL-1414) > > Extend org.apache.drill.exec.store.sys.PStore interface to add two additional > functions > > public V getBlob(String key); > public void putBlob(String key, V value); > > Now these two methods can be used by the consumers to store large amount of > data, that may not require frequent enumeration and not suitable for storage > on systems like Zookeeper. A particular PStore implementation could choose to > store the blob data differently than the primary value, for example, HBase > PStore provider could store them in a different column family while Zookeeper > PStore provider can store them on DFS (as this JIRA summary suggests). > > The Query Profile, then can be split into two part where small, meta info > about the query is stored with a put() while the fragment profiles are stored > using putBlob(). > > > Diffs > ----- > > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePStore.java > 6324180 > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePStoreProvider.java > 48e6c42 > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > c210541 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ProfileResources.java > 9cbc2e7 > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PStore.java > e6cca8c > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/local/LocalPStore.java > 35e4aea > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/local/NoWriteLocalPStore.java > 435bd0d > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkPStore.java > eb21c70 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkPStoreProvider.java > f4513c2 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryStatus.java > 45a151e > exec/java-exec/src/main/resources/rest/profile/list.ftl 76f9a07 > > Diff: https://reviews.apache.org/r/26087/diff/ > > > Testing > ------- > > All existing unit tests pass. I'll add more tests for this change soon. > > > Thanks, > > Aditya Kishore > >
