----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26132/ -----------------------------------------------------------
Review request for drill and Aman Sinha. Repository: drill-git Description ------- We initialize the hash table with both build and probe expressions. However if the two expressions are of different types (eg: float and int) then the hash value will be different even if the two values on both sides are same. This patch fixes it so that we apply casts before performing the hash function so that same values result in same hash values. Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 2854c14 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java f77407e exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java 7969d49 exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 388d057 Diff: https://reviews.apache.org/r/26132/diff/ Testing ------- Added unit test that has float and int on either side of the join condition. Thanks, Mehant Baid
