The good news: I tried using 1.8.0-b132 on mac os x. All tests passed. The bad news: I tried again on ubuntu 14.04.1 with the latest jdk 1.8 (1.8.0_20-b26) and got a test failure on two runs. (Sorry, I wiped away the log. But it looked like a real test failure.) So, it’s worth testing linux.
Also, regarding your remarks that people should do a ‘clean’ before these runs. Of course it makes sense to clean after checking out a new branch, but I hope you intend that people can run Drill using JDK 1.8 even on binaries built using JDK 1.7. It would be awkward to require different binaries for different runtime JDKs. Julian On Oct 5, 2014, at 8:51 PM, Julian Hyde <[email protected]> wrote: > Aditya, > > I tried your branch on JDK 1.8.0-b132 / Ubuntu linux 14.04. It builds > and the test suite passes. > > I'll try on JDK 1.8 mac os tomorrow. > > Julian > > On Fri, Oct 3, 2014 at 7:20 PM, Aditya <[email protected]> wrote: >> I have pushed the 3 patches required for Drill to build and run unit tests >> with JDK8 to my private branch [1]. Now all tests are passing on my >> machine. Can few more people give it a try? >> >> [1] https://github.com/adityakishore/incubator-drill/tree/JAVA-8-SUPPORT >> >> On Fri, Oct 3, 2014 at 5:54 PM, Tomer Shiran <[email protected]> wrote: >> >>> Makes sense. As long as we say what JDK version is supported we are fine. >>> We can expand the compatibility matrix in the next release. >>> >>> >>> >>>> On Oct 3, 2014, at 1:13 PM, Aditya <[email protected]> wrote: >>>> >>>> I agree. This is not critical enough to sink the RC. >>>> >>>> On Fri, Oct 3, 2014 at 1:09 PM, Steven Phillips <[email protected]> >>>> wrote: >>>> >>>>> We should update the INSTALL.md to correctly reflect that Drill requires >>>>> JDK 7.x, not 7+. >>>>> >>>>> I am disinclined to say that we should roll a new release candidate, >>>>> though. But I would be okay with it, if anyone else thinks we should. >>>>> >>>>>> On Fri, Oct 3, 2014 at 12:59 PM, Aditya <[email protected]> >>> wrote: >>>>>> >>>>>> So I guess it should be okay to not hold the release for this. >>>>>> >>>>>> On Fri, Oct 3, 2014 at 12:53 PM, Julian Hyde <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> The test suite succeeds under JDK 1.7. >>>>>>> >>>>>>>> On Oct 3, 2014, at 11:45 AM, Julian Hyde <[email protected]> >>> wrote: >>>>>>>> >>>>>>>> Haven’t tried 1.7. Trying it now. >>>>>>>> >>>>>>>>> On Oct 3, 2014, at 11:43 AM, Aditya <[email protected]> >>> wrote: >>>>>>>>> >>>>>>>>> Is the test failure only with 1.8? Did it pass with 1.7? >>>>>>>>> >>>>>>>>> On Fri, Oct 3, 2014 at 11:41 AM, Julian Hyde <[email protected]> >>>>>>> wrote: >>>>>>>>> >>>>>>>>>> -0 binding >>>>>>>>>> >>>>>>>>>> - downloaded src tarball, verified signatures, ran “mvn install” >>>>>>>>>> (including tests) under jdk 1.8 on mac os x >>>>>>>>>> - got 1 error in TestClassTransformation and 3 errors in >>>>>>>>>> TestTpchSingleMode; details in [1] >>>>>>>>>> >>>>>>>>>> I suspect the problems are due to JDK 1.8. INSTALL.md implies that >>>>>> it >>>>>>>>>> should work on 1.8. Voting -0 — looks fishy, but I’ll let others >>>>>> make >>>>>>> the >>>>>>>>>> call whether this release is bad. >>>>>>>>>> >>>>>>>>>> Julian >>>>>>>>>> >>>>>>>>>> [1] https://issues.apache.org/jira/browse/DRILL-1489 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Oct 3, 2014, at 9:30 AM, Jason Altekruse < >>>>>> [email protected]> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> +1 binding >>>>>>>>>>> >>>>>>>>>>> - downloaded both tarballs and verified signatures >>>>>>>>>>> - unit tests are passing on the source release on Mac >>>>>>>>>>> - started binary release in embedded mode and checked that the web >>>>>> UI >>>>>>>>>> came >>>>>>>>>>> up and was working as expected >>>>>>>>>>> - ran a few queries through sqlline >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Fri, Oct 3, 2014 at 1:14 AM, Timothy Chen <[email protected]> >>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> +1 binding >>>>>>>>>>>> >>>>>>>>>>>> mvn install passes on Ubuntu 14.04, jdk 1.7 >>>>>>>>>>>> >>>>>>>>>>>> Tim >>>>>>>>>>>> >>>>>>>>>>>> On Fri, Oct 3, 2014 at 12:44 AM, Yash Sharma <[email protected]> >>>>>>> wrote: >>>>>>>>>>>>> +1 Non Binding >>>>>>>>>>>>> >>>>>>>>>>>>>> Link contains source & binary distributions. >>>>>>>>>>>>>> Both distributions contain README, NOTICE, LICENSE Files. >>>>>>> INSTALL.md >>>>>>>>>>>>> present for source distro. >>>>>>>>>>>>>> Verified Checksums (md5+sha) for src and binary distributions. >>>>>>>>>>>>>> Able to build from source distribution >>>>>>>>>>>>>> Able to launch drill from source & binary distribution (Embeded >>>>>>> mode). >>>>>>>>>>>>>> Able to basic queries using sqlline and web interface. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Fri, Oct 3, 2014 at 5:53 AM, Steven Phillips < >>>>>>>>>> [email protected]> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> I am not aware of anything we promised to fix. >>>>>>>>>>>>>> >>>>>>>>>>>>>> There were some packaging issues that were brought up, but I >>>>>>> thought >>>>>>>>>> we >>>>>>>>>>>>>> fixed them and rolled new release candidates last time. The >>>>>> changes >>>>>>>>>>>> made at >>>>>>>>>>>>>> that time I believe are still in present. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Even anyone is aware of something that we were supposed to fix >>>>>> for >>>>>>>>>> this >>>>>>>>>>>>>> release, please let me know so I can take care of them asap. >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Thu, Oct 2, 2014 at 5:13 PM, Ted Dunning < >>>>>> [email protected] >>>>>>>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> I just got off an airplane. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Has anybody besides Aditya looked at packaging aspects? What >>>>>>> about >>>>>>>>>>>> the >>>>>>>>>>>>>>> issues from the last release that we promised to fix in this >>>>>>> release? >>>>>>>>>>>>>> Were >>>>>>>>>>>>>>> there any such? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Thu, Oct 2, 2014 at 6:03 PM, Neeraja Rentachintala < >>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> +1 (non-binding) >>>>>>>>>>>>>>>> - Downloaded the tar ball and played with a variety of JSON >>>>>>> datasets >>>>>>>>>>>>>>>> - Configured and queried data from MongoDB >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Thu, Oct 2, 2014 at 2:59 PM, Jinfeng Ni < >>>>>>> [email protected]> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> +1 >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> 1. Download source tar ball. Build and run the whole unit >>>>>> test >>>>>>>>>>>>>> suites >>>>>>>>>>>>>>> on >>>>>>>>>>>>>>>>> Mac. Start sqlline in embedded mode and run sample queries. >>>>>> All >>>>>>>>>>>>>>>> successful. >>>>>>>>>>>>>>>>> 2. Download binary tar ball. Start sqlline in embedded >>> mode, >>>>>>> run >>>>>>>>>>>>>>> sample >>>>>>>>>>>>>>>>> queries. All successful. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Thu, Oct 2, 2014 at 10:33 AM, Tomer Shiran < >>>>>>> [email protected]> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> +1 binding >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Thu, Oct 2, 2014 at 3:06 AM, Steven Phillips < >>>>>>> [email protected] >>>>>>>>>>>>> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Greetings, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> I would like to propose the release of Apache Drill, >>>>>> version >>>>>>>>>>>>>>>>>>> 0.6.0-incubating. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> This release includes 37 resolved JIRAs [1]. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> The artifacts are hosted at [2]. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> The vote will be open for 72 hours, ending 3 AM Pacific, >>>>>>>>>>>> October >>>>>>>>>>>>>> 5, >>>>>>>>>>>>>>>>> 2014. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> [ ] +1 >>>>>>>>>>>>>>>>>>> [ ] +0 >>>>>>>>>>>>>>>>>>> [ ] -1 >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Please indicate whether your vote is binding or >>>>>> non-binding. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Thank you, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Steven >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> [1] >>>>>> https://issues.apache.org/jira/browse/DRILL/fixforversion/12327472/ >>>>>>>>>>>>>>>>>>> [2] http://people.apache.org/~smp/apache-drill-0.6.0.rc0/ >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Steven Phillips >>>>>>>>>>>>>> Software Engineer >>>>>>>>>>>>>> >>>>>>>>>>>>>> mapr.com >>>>> >>>>> >>>>> >>>>> -- >>>>> Steven Phillips >>>>> Software Engineer >>>>> >>>>> mapr.com >>>>> >>>
