----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26769/ -----------------------------------------------------------
(Updated Oct. 20, 2014, 8:54 p.m.) Review request for drill, Aditya Kishore, Jinfeng Ni, Mehant Baid, and Timothy Chen. Changes ------- Clean patch with new operator support and Testcases. Summary (updated) ----------------- DRILL-82: Pig Latin support Repository: drill-git Description (updated) ------- Updated Patch with support for new operators and expressions. Added testcases with Pig Latin Scripts. Operators Supported: LOAD, STORE, FILTER, UNION, JOIN, DISTINCT, LIMIT TestCases: org.apache.drill.exec.pigparser.TestPigLatinOperators Fact check: - LOAD: Supports delimited text files only. Picks delimeter provided in PigStorage(). Default \t. Reads from Local Filesystem currently. (pig -x local) - STORE: Only dumps on --SCREEN-- for now. - JOIN: Inner, LeftOuter, RightOuter, FullOuter (not supported by drill currently though). Only supports alias based joins not index based($0 etc). Open ends for Discussion: - Sqlline Hack: Need to take a call on this. One solution is suggested by Julian to have a custom Sqlline with both versions of JLine - so as to have compatibility with Pig's Sqlline - Drill's jdbc-all's build failure: Not able to pass through jdbc-all's Obfuscation failure error. Solution suggested by Aditya did not help me (removed jetty's jars along with other dependencies). Any tips would be appreciated here. Diffs (updated) ----- common/src/main/java/org/apache/drill/common/expression/UnquotedFieldReference.java PRE-CREATION common/src/main/java/org/apache/drill/common/logical/data/Join.java df7e583 exec/java-exec/pom.xml d05e4c6 exec/java-exec/src/main/java/org/apache/drill/exec/exception/PigParsingException.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/pigparser/parser/PigLatinParser.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/pigparser/planconverter/PigExpressionVisitor.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/pigparser/planconverter/PigPlanTranslator.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/pigparser/planconverter/PigPlanVisitor.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/pigparser/util/PigParserUtil.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillImplementor.java 7fff6e9 exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java 7bf3909 exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 0a34a22 exec/java-exec/src/main/resources/rest/query/query.ftl 5033aca exec/java-exec/src/test/java/org/apache/drill/exec/pigparser/TestPigLatinOperators.java PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-composite-plan.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-dag-pruning.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-distinct.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-filter.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-inner-join.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-left-join.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-limit.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-load-store-custom-delim.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-load-store.txt PRE-CREATION exec/java-exec/src/test/resources/pigparsing/pigscripts/pig-right-join.txt PRE-CREATION exec/java-exec/src/test/resources/store/text/data/nations_caratseparated.txt PRE-CREATION exec/java-exec/src/test/resources/store/text/data/nations_tsv.txt PRE-CREATION exec/java-exec/src/test/resources/store/text/data/regions_withduplicate.csv PRE-CREATION exec/jdbc-all/pom.xml 349366b exec/pom.xml f27320e pom.xml 70abb75 protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java 4f01053 protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryType.java 6c8f3c5 protocol/src/main/java/org/apache/drill/exec/proto/beans/RpcType.java 3f1f9fd protocol/src/main/protobuf/UserBitShared.proto 3ad9a09 Diff: https://reviews.apache.org/r/26769/diff/ Testing (updated) ------- Tested via Drill Web Interface and Testcases. TestCases with PigScripts: org.apache.drill.exec.pigparser.TestPigLatinOperators Thanks, Yash Sharma
