----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26696/#review57446 -----------------------------------------------------------
Ship it! Ship It! - Jason Altekruse On Oct. 15, 2014, 8:44 p.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26696/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 8:44 p.m.) > > > Review request for drill and Jason Altekruse. > > > Repository: drill-git > > > Description > ------- > > Consider the following JSON: > {"x":{ "y": "kevin", "z": "paul" } } > > Now this UDF would transform the map 'x' in the following manner > [ {"key":"y","value":"kevin"}, {"key":"z","value":"paul"}] > > Currently this function only supports simple map as input and poses the > following two conditions on the values within the map > 1. They should be of the same type > 2. They can only be scalar types > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Mappify.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MappifyUtility.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapUtility.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestComplexTypeReader.java > 2e62897 > exec/java-exec/src/test/resources/jsoninput/input3.json PRE-CREATION > > Diff: https://reviews.apache.org/r/26696/diff/ > > > Testing > ------- > > Added unit tests and ran some manual tests via sqlline. > > > Thanks, > > Mehant Baid > >
