----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27026/#review57855 -----------------------------------------------------------
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseFilterBuilder.java <https://reviews.apache.org/r/27026/#comment98730> There is a utility function which will convert from SQL like pattern into java regex pattern. You may use that driectly. org.apache.drill.exec.expr.fn.impl.RegexpUtil.sqlToRegexLike Also, LIKE operator could have ESCAPE. You may need consider the ESCAPE character (The utility method allows to pass the ESCAPE character). - Jinfeng Ni On Oct. 22, 2014, 12:34 a.m., Aditya Kishore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27026/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 12:34 a.m.) > > > Review request for drill, Jacques Nadeau and Steven Phillips. > > > Bugs: DRILL-1508 > https://issues.apache.org/jira/browse/DRILL-1508 > > > Repository: drill-git > > > Description > ------- > > The attached patch translate a LIKE operator in a WHERE clause into a > `RegexStringComparator()` when applicable. > > > Diffs > ----- > > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/CompareFunctionsProcessor.java > 6810f81 > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseFilterBuilder.java > ee011a5 > > contrib/storage-hbase/src/test/java/org/apache/drill/hbase/HBaseTestsSuite.java > 18cf87c > > contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseFilterPushDown.java > 29e7033 > > contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestTableGenerator.java > ccf5ad5 > > Diff: https://reviews.apache.org/r/27026/diff/ > > > Testing > ------- > > Added two new unit test cases `testFilterPushDownRowKeyLike()` and > `testFilterPushDownRowKeyRangeAndColumnValueLike()`. > > > Thanks, > > Aditya Kishore > >
