> On Oct. 22, 2014, 5:55 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushPartitionFilterIntoScan.java, > > line 51 > > <https://reviews.apache.org/r/27008/diff/1/?file=728488#file728488line51> > > > > Would be good to have a method in GroupScan instead of doing > > instanceof. Or, alternatively, you could do the check inside > > supportsPartitionFilterPushdown()
After a brief discussion we decided to leave it. - Mehant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27008/#review57750 ----------------------------------------------------------- On Oct. 23, 2014, 9:20 p.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27008/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 9:20 p.m.) > > > Review request for drill and Aman Sinha. > > > Repository: drill-git > > > Description > ------- > > This patch adds support for partition pruning on hive tables. > > Patch mainly involves factoring out/ extending logic in file system based > partition pruning to apply for Hive. > > > Diffs > ----- > > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java > PRE-CREATION > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/HivePushPartitionFilterIntoScan.java > PRE-CREATION > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveReadEntry.java > 13845ae > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java > 303fc3c > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java > e221707 > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/TestHivePartitionPruning.java > PRE-CREATION > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java > 7b2c9b6 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionDescriptor.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DirPathBuilder.java > eeb664d > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushPartitionFilterIntoScan.java > 19a92f0 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PartitionPruningUtil.java > PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/PlanTestBase.java 0c75640 > > Diff: https://reviews.apache.org/r/27008/diff/ > > > Testing > ------- > > Added unit tests > > > Thanks, > > Mehant Baid > >
