----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27215/#review58581 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java <https://reviews.apache.org/r/27215/#comment99640> Good point, it is happening on an rpc thread. With the fragments batched per node, this shouldn't be a huge problem since it can't deadlock itself. I suppose it is possible to deadlock the system if you had twenty queries on twenty different nodes to start simultaneously. The alternative is to run this on a separate thread and not ack/exception back to the sender until the thread terminates. I hate creating this kind of thread but I'm not sure of a better solution. - Jacques Nadeau On Oct. 27, 2014, 1:45 a.m., Jacques Nadeau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27215/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 1:45 a.m.) > > > Review request for drill and Steven Phillips. > > > Repository: drill-git > > > Description > ------- > > Includes: > - Remove dependency on Infinispan > - Update initialize fragments to send in batches. > - Update RPC layer to capture UserRpcExceptions and propagate back. > - Send full stack trace in DrillPBError and let foreman node decide on > formatting. > - Increment control rpc version > - Update systables to report current drillbit and version > > > Diffs > ----- > > exec/java-exec/pom.xml d05e4c6 > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/infinispan/ICache.java > 6627a89 > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/infinispan/JacksonAdvancedExternalizer.java > 55633ab > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/infinispan/ProtobufAdvancedExternalizer.java > 7b638ee > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/infinispan/VAAdvancedExternalizer.java > f072628 > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/infinispan/ZookeeperCacheStore.java > 46d4eca > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/local/LocalCache.java > 99ead1c > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java > 2d69ca3 > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java > a9b0c61 > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java > 0564c1a > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java > 22872f9 > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java > 1ad144d > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java > bd15ac9 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java > c594e70 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java > aecf363 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/StatusHandler.java > 469140c > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BaseRpcOutcomeListener.java > 10ae6e3 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/CoordinationQueue.java > 8f43b06 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/OutboundRpcMessage.java > edad63e > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RemoteRpcException.java > d75e902 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcBus.java 918ca0b > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcEncoder.java > 34256f3 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcException.java > eb870b3 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/UserRpcException.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlRpcConfig.java > 31fbe7b > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlTunnel.java > d035c10 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java > 45acd13 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java > 2c6e02c > exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java > 2125166 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java > 7d48711 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/RemoteServiceSet.java > 96e9d8e > > exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java > 86b0a23 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/DrillbitIterator.java > 844fd68 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java > 4301f12 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java > 743ab53 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/VersionIterator.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/work/ErrorHelper.java > 51b4e32 > exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java > 0407361 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlHandlerImpl.java > 0ac606c > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java > d00478b > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > 0a34a22 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentData.java > b9b3de0 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java > a01a5f6 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/AbstractStatusReporter.java > 1983ebb > exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java 7fc7d6b > exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java bfa97d1 > > exec/java-exec/src/test/java/org/apache/drill/exec/cache/TestCacheSerialization.java > d507913 > > exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java > 896cf4d > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java > a62409b > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/orderedpartitioner/TestOrderedPartitionExchange.java > 8419860 > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java > d408773 > > exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java > f450e5d > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java bfc1b8a > protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java 6229d9a > protocol/src/main/java/org/apache/drill/exec/proto/GeneralRPCProtos.java > 5e37123 > protocol/src/main/java/org/apache/drill/exec/proto/SchemaBitControl.java > 7b2c4d7 > > protocol/src/main/java/org/apache/drill/exec/proto/SchemaGeneralRPCProtos.java > 087cc0d > protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserBitShared.java > 23fcf21 > protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java > 4f01053 > protocol/src/main/java/org/apache/drill/exec/proto/beans/DrillPBError.java > 303f9b6 > > protocol/src/main/java/org/apache/drill/exec/proto/beans/ExceptionWrapper.java > PRE-CREATION > > protocol/src/main/java/org/apache/drill/exec/proto/beans/InitializeFragments.java > PRE-CREATION > > protocol/src/main/java/org/apache/drill/exec/proto/beans/StackTraceElementWrapper.java > PRE-CREATION > protocol/src/main/protobuf/BitControl.proto 4398b63 > protocol/src/main/protobuf/GeneralRPC.proto 48011bf > protocol/src/main/protobuf/UserBitShared.proto 3ad9a09 > > Diff: https://reviews.apache.org/r/27215/diff/ > > > Testing > ------- > > TPCHSF100 on 10 nodes, existing regression and unit tests. > > > Thanks, > > Jacques Nadeau > >
