----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27019/#review58853 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/27019/#comment100006> Why put a warning here? If we recieved a record batch, then it should not contain QueryState message, at least for now. - Xiao Meng On Oct. 22, 2014, 5:52 a.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27019/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 5:52 a.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > Client may get record batches that contain no rows. The c++ client still > tried to build the value vectors without checking if there were no rows and > the code would assert. > > > Diffs > ----- > > contrib/native/client/example/querySubmitter.cpp 040f9d7 > contrib/native/client/src/clientlib/drillClientImpl.cpp 2f27b48 > contrib/native/client/src/clientlib/recordBatch.cpp dfa12fd > contrib/native/client/src/include/drill/recordBatch.hpp de65202 > > Diff: https://reviews.apache.org/r/27019/diff/ > > > Testing > ------- > > Build and tested a query with zero records returned on Windows/Linux/Mac > > > Thanks, > > Parth Chandra > >
