-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23941/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 1:36 a.m.)
Review request for drill and Parth Chandra.
Changes
-------
Rebased and addressed comments.
The client will cancel all async I/O operation when query timed out. Thus, if
there is one query timed out, the other queries will be cancelled.
Is it a reasonable choice? Maybe we should use one query timeer for each query
but it seems over complicated. Any opinons?
The discussion can be seprated from the patch though.
Bugs: DRILL-1197
https://issues.apache.org/jira/browse/DRILL-1197
Repository: drill-git
Description (updated)
-------
- add trace logging for error handling.
- return more detailed connection status for validate handshake
- some bug fixes for time out
- add options queryTimeout and handshakeTimout to querySubmitter
It depends on DRILL-1679.
Diffs (updated)
-----
contrib/native/client/example/querySubmitter.cpp
7b98bc97b82e142904be97bf5b3ff245c418fdc8
contrib/native/client/src/clientlib/drillClient.cpp
70058ec360f404e473c497cbb86d5e53a98f5bbb
contrib/native/client/src/clientlib/drillClientImpl.hpp
8e2f437f366d6e84cd8b4d6063a7728316421e5d
contrib/native/client/src/clientlib/drillClientImpl.cpp
cc70020383b115951488e1552ae1fecb520674fd
contrib/native/client/src/clientlib/errmsgs.hpp
9a69f213cab4ad72c1746ad174b1d711777d255f
contrib/native/client/src/clientlib/errmsgs.cpp
7a7fa6a38bf47ade19e1806b912b03afa29503a2
contrib/native/client/src/include/drill/common.hpp
59537f151dfb2a240222bc3114c06013ee85a2f8
contrib/native/client/src/include/drill/drillClient.hpp
65c07d6a95ca91e25ebbf165f4b54314b9916b22
Diff: https://reviews.apache.org/r/23941/diff/
Testing (updated)
-------
Test case:
1. handshake phase. Run a listening port (say port 1234) and set timeout to 5.
$ nc -l 1234
2. query phase. Run a query like TPCH-12 and set the query timeout with 1
second.
Thanks,
Xiao Meng
