> On Nov. 25, 2014, 12:12 a.m., Aman Sinha wrote: > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java, > > line 93 > > <https://reviews.apache.org/r/28417/diff/1/?file=774768#file774768line93> > > > > This value is not initialized and only assigned to in the copy > > constructor (other 2 constructors are not doing anything with it).
This value is being computed inside getSplits() which in turn is called by the 2 constructors. > On Nov. 25, 2014, 12:12 a.m., Aman Sinha wrote: > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java, > > line 293 > > <https://reviews.apache.org/r/28417/diff/1/?file=774768#file774768line293> > > > > Why does the estRowCount need to be here if it is not being used any > > more ? Indeed, but the new patch does use it after all > On Nov. 25, 2014, 12:12 a.m., Aman Sinha wrote: > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java, > > line 162 > > <https://reviews.apache.org/r/28417/diff/1/?file=774768#file774768line162> > > > > An assumption here is that the numRows property is always > > available...you should handle the scenario when it isn't. I will submit a patch right away to fix this - abdelhakim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28417/#review62903 ----------------------------------------------------------- On Nov. 25, 2014, 12:13 a.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28417/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 12:13 a.m.) > > > Review request for drill. > > > Bugs: DRILL-1742 > https://issues.apache.org/jira/browse/DRILL-1742 > > > Repository: drill-git > > > Description > ------- > > HiveScan.getSplits() already gets the table and partitions metadata using > MetaStoreUtils. > We compute the total number of rows using the numRows property and store the > computed number of rows in rowCount attribute which is later returned by > getScanStats(). > > > Diffs > ----- > > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java > ddbc100 > > Diff: https://reviews.apache.org/r/28417/diff/ > > > Testing > ------- > > created several partitioned and non-partitioned tables, loaded data in hive. > > used explain plan to check the number of rows when the whole table is queried > and also when specific partitions are queried (to make sure the row count > takes hive partition pruning into account) > > > Thanks, > > abdelhakim deneche > >
