[EMAIL PROTECTED] wrote:
On (06/23/07 12:33), Garrett D'Amore wrote:
But link_speed isn't listed in ieee802.3(5) -- so does this mean we'll use
"speed"?  More generally, I'm not convinced that reusing those names is
the right choice (Do we really want to have a "link_up" property?  Or do
I don't care *what* we choose, but we have to pick something. Right now the anarchy and inconsistencies is really, really infuriating. At the moment, the ieee802.3(5) man page seems to be the "documented" set, so it makes sense to use that. It may be that other adjustments (link_speed -> speed ?) are needed. But one or the other of the implementation or the documentation needs to be fixed.

A very relevant CR on this subject is 6544195.

Perhaps we should just report (and use the name) ifspeed, since it's
already easily recognized.

Heh, I forgot about that CR... one of the first I filed after coming back to Sun. :-)

ifspeed is the kstat that has been used for decades now, although not always consistently. (Sometimes the units have been Mbps. Sometimes they have been just bps.)

Again, we need to just pick something, and stick to it.

And this problem shows up in a bunch of the other kstats too.

Frankly, at this point, I'd really like to see an implementation advice to developers about what stats to report, and they should represent. (For example, what counts as an ierror? What counts as a macrcv error? What is the difference between first_collisions, multi_collisions, ex_collisions, and collisions? What about collisions detected on rx instead of just tx? Etc. Should opackets/obytes count packet transmission attempts, or only successfully transmitted packets? Etc.

   -- Garrett
--Sowmini

_______________________________________________
driver-discuss mailing list
driver-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/driver-discuss

Reply via email to