You're brave. :-) I hadn't even tested the code myself yet.
I'll have a look at this later today.
-- Garrett
Juergen Keil wrote:
> Garrett wrote:
>
>
>> For those who've wanted it, I posted the webrev from the dnet conversion
>> that I did at OpenSolaris Developer Summit 2007 at
>> http://cr.opensolaris.org/~gdamore/dnet-suspend/
>>
>
> Just tried that dnet patch on my ASUS P2B-LS "S3 suspend-to-ram" test box,
> but it's crashing the box with a failed assertion panic during driver resume:
>
> assertion failed: mutex_owned((&dnetp->intrlock)), in file dnet.c line 2308
>
> stack backtrace shows
>
> :panic...
> dnet:set_sia+12c(...)
> dnet:dnet_init_board+2a(...)
> dnet:dnetattach+5bd(..., 1)
> ...
>
> (messages manually copied, disk device is suspended, so no crash dump :-)
>
>
> I think the "dnet_init_board(macinfo);" call in the dnetattach()
> DDI_RESUME case should be moved after the mutex_enter() calls.
>
>
> With that change, suspend / resume does not panic any more.
>
> But the dnet device seems to be dead after a resume. And after maybe
> a minute, I got another panic when I tried an "ifconfig -a" after the
> resume:
>
>
>> ::status
>>
> debugging crash dump vmcore.3 (32-bit) from elise
> operating system: 5.11 wos_b78_debug (i86pc)
> panic message:
> assertion failed: connp->conn_oper_pending_ill == 0, file:
> ../../common/inet/ip/
> ipclassifier.c, line: 2219
> dump content: kernel pages only
>
>> $C
>>
> ccdd6c58 vpanic(feae72dc, fa2a1fc4, fa2a2b18, 8ab)
> ccdd6c78 assfail+0x5a(fa2a1fc4, fa2a2b18, 8ab)
> ccdd6c98 ipcl_conn_cleanup+0x209(cde9f540)
> ccdd6cc8 ipcl_conn_destroy+0x151()
> ccdd6ce0 udp_close+0xb8(cdbd3ca8, 3, cd552690)
> ccdd6d08 qdetach+0x9b(cdbd3ca8, 1, 3, cd552690, 0)
> ccdd6d50 strclose+0x392(cde09580, 3, cd552690)
> ccdd6d80 socktpi_close+0x1cc(cde09580, 3, 1, 0, 0, cd552690)
> ccdd6dcc fop_close+0x51(cde09580, 3, 1, 0, 0, cd552690)
> ccdd6e18 closef+0x88(cd3bd700)
> ccdd6e48 closeall+0x58(cb6bf9a4)
> ccdd6e90 proc_exit+0x40a(2, 2)
> ccdd6ea4 exit+0x11(2, 2)
> ccdd6efc psig+0x4c3()
> ccdd6f7c post_syscall+0x3f6(4, cc6f3880)
> ccdd6f90 syscall_exit+0x48(cc6f3880, 4, cc6f3880)
> ccdd6fa4 sys_call+0x21a()
>
>
>
>> ::msgbuf
>>
> ...
> System is being suspended
> NOTICE: acpica_ddi_setwake: could not get handle for /[EMAIL
> PROTECTED],0/pci10b9,[EMAIL PROTECTED], ohci:0
> NOTICE: acpica_ddi_setwake: could not get handle for /[EMAIL
> PROTECTED],0/pci10b9,[EMAIL PROTECTED],1, ohci:1
> NOTICE: acpica_ddi_setwake: could not get handle for /[EMAIL
> PROTECTED],0/pci10b9,[EMAIL PROTECTED],2, ohci:2
> NOTICE: acpica_ddi_setwake: could not get handle for /[EMAIL
> PROTECTED],0/pci10b9,[EMAIL PROTECTED],3, ehci:0
> NOTICE: acpica_ddi_setwake: could not get handle for /[EMAIL
> PROTECTED],0/pci10b9,[EMAIL PROTECTED],3, ehci:0
> NOTICE: acpica_ddi_setwake: could not get handle for /[EMAIL
> PROTECTED],0/pci10b9,[EMAIL PROTECTED],2, ohci:2
> NOTICE: acpica_ddi_setwake: could not get handle for /[EMAIL
> PROTECTED],0/pci10b9,[EMAIL PROTECTED],1, ohci:1
> NOTICE: acpica_ddi_setwake: could not get handle for /[EMAIL
> PROTECTED],0/pci10b9,[EMAIL PROTECTED], ohci:0
>
> The system is back where you left!
> System has been resumed.
>
> panic[cpu0]/thread=cc6f3880:
> assertion failed: connp->conn_oper_pending_ill == 0, file:
> ../../common/inet/ip/
> ipclassifier.c, line: 2219
>
>
> ccdd6c78 genunix:assfail+5a (fa2a1fc4, fa2a2b18,)
> ccdd6c98 ip:ipcl_conn_cleanup+209 (cde9f540)
> ccdd6cc8 ip:ipcl_conn_destroy+151 (cde9f540, cd5cf27c,)
> ccdd6ce0 ip:udp_close+b8 (cdbd3ca8, 3, cd5526)
> ccdd6d08 genunix:qdetach+9b (cdbd3ca8, 1, 3, cd5)
> ccdd6d50 genunix:strclose+392 (cde09580, 3, cd5526)
> ccdd6d80 sockfs:socktpi_close+1cc (cde09580, 3, 1, 0, )
> ccdd6dcc genunix:fop_close+51 (cde09580, 3, 1, 0, )
> ccdd6e18 genunix:closef+88 (cd3bd700)
> ccdd6e48 genunix:closeall+58 (cb6bf9a4)
> ccdd6e90 genunix:proc_exit+40a (2, 2)
> ccdd6ea4 genunix:exit+11 (2, 2)
> ccdd6efc genunix:psig+4c3 (ccdd6f90, 8047a54, )
> ccdd6f7c genunix:post_syscall+3f6 (4, cc6f3880)
> ccdd6f90 genunix:syscall_exit+48 (cc6f3880, 4, cc6f38)
>
> syncing file systems...
> done
> dumping to /dev/dsk/c0d0s1, offset 83951616, content: kernel
>
>> ::cpuinfo -v
>>
> ID ADDR FLG NRUN BSPL PRI RNRN KRNRN SWITCH THREAD PROC
> 0 fec24b98 1b 1 0 59 no no t-0 cc6f3880 ifconfig
> | |
> RUNNING <--+ +--> PRI THREAD PROC
> READY 60 ca94cde0 sched
> EXISTS
> ENABLE
>
>
>
_______________________________________________
driver-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/driver-discuss
