Please don't flame me :) I'm getting my feet wet with kernel contribution.
One example I saw in a video by GKH suggested cleaning up coding style as a 
good first commit.

Signed-off-by: Sean Williams <uni...@gmail.com>
---
 drivers/staging/comedi/drivers/ni_at_a2150.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_at_a2150.c 
b/drivers/staging/comedi/drivers/ni_at_a2150.c
index 2512ce8..c77d343 100644
--- a/drivers/staging/comedi/drivers/ni_at_a2150.c
+++ b/drivers/staging/comedi/drivers/ni_at_a2150.c
@@ -684,13 +684,12 @@ static int a2150_set_chanlist(struct comedi_device *dev,
                devpriv->config_bits |= CHANNEL_BITS(0x4 | start_channel);
                break;
        case 2:
-               if (start_channel == 0) {
+               if (start_channel == 0)
                        devpriv->config_bits |= CHANNEL_BITS(0x2);
-               } else if (start_channel == 2) {
+               else if (start_channel == 2)
                        devpriv->config_bits |= CHANNEL_BITS(0x3);
-               } else {
+               else
                        return -1;
-               }
                break;
        case 4:
                devpriv->config_bits |= CHANNEL_BITS(0x1);
-- 
1.8.1.2

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to