On Tue, Oct 1, 2013 at 12:09 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
>> @@ -306,7 +316,16 @@ int dgap_tty_register(struct board_t *brd)
>>
>> DPR_INIT(("DGAP REGISTER TTY: MAJORS: %d %d\n",
>> brd->SerialDriver->major,
>> brd->PrintDriver->major));
>> -
>
> You need a "return 0;" here otherwise we release everything on success
> when we worked so hard to allocate it.
>
> regards,
> dan carpenter
When I add that I get these smatch warnings:
drivers/staging/dgap/dgap_tty.c:323 dgap_tty_register() info: ignoring
unreachable code.
drivers/staging/dgap/dgap_tty.c:323 dgap_tty_register() info: ignoring
unreachable code.
Ignore these warnings?
Thanks,
Lidza
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
