On 10/18/2013 05:08 PM, Ben Hutchings wrote:
On Fri, 2013-10-18 at 16:34 -0500, Larry Finger wrote:
Sparse checking results in the following warnings:

    CHECK   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes
address space of expression
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3933:31: warning: incorrect type
in argument 1 (different address spaces)
[...]
-               DBG_88E("[%s] extra = %s\n", __func__, (char 
*)wrqu->data.pointer);
-       if (!memcmp(wrqu->data.pointer, "status", 6)) {
+               DBG_88E("[%s] extra = %s\n", __func__, (__force char 
*)wrqu->data.pointer);
+       if (!memcmp((__force const char *)wrqu->data.pointer, "status", 6)) {
[...]

This is hiding the problem, not fixing it.

This private interface needs to be removed anyway.

I agree, but that is not likely to happen soon. I will just leave this set of Sparse warnings alone.

Larry


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to