On Sun, Oct 20, 2013 at 03:45:46PM -0700, Lisa Nguyen wrote:
> Modified all structs in libcfs_hash header file to eliminate
> the "Do not add new typedefs" warning generated by checkpatch.pl
> and meet kernel coding style.
> 
> Signed-off-by: Lisa Nguyen <l...@xenapiadmin.com>

This patch breaks the build so badly, I know you didn't test it alone :(

Your follow-on patches do fix up the build breakage, which is nice, but
you can never break the build with any individual patch, that's not how
kernel development works, sorry.

So, can you change this to just fix one typedef at a time, for the whole
chunk of code?  That should be managable, and reviewable, instead of
having to put all 22 patches here into one big patch (which isn't ok.)

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to