On Tue, Nov 19, 2013 at 09:39:19PM -0800, Greg KH wrote:
> On Tue, Nov 19, 2013 at 08:56:59PM -0500, Josh Boyer wrote:
> > On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote:
> > > On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote:
> > > > commit b8d181e408af (staging: drm/imx: add drm plane support) added a 
> > > > file
> > > > to the make target for DRM_IMX_IPUV3 but didn't adjust the objs required
> > > > to actually build that as a module.  Kbuild got confused and this lead 
> > > > to
> > > > link errors like:
> > > > 
> > > > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] 
> > > > undefined!
> > > > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] 
> > > > undefined!
> > > > 
> > > > Additionally, it added a call to imx_drm_crtc_id which also fails with a
> > > > link error as above.  To fix this, we adjust the make target with the 
> > > > proper
> > > > objs, which will change the name of the resulting .ko.  We also add an
> > > > EXPORT_SYMBOL_GPL for imx_drm_crtc_id.
> > > > 
> > > > Signed-off-by: Josh Boyer <jwbo...@fedoraproject.org>
> > > 
> > > 
> > > Acked-by: Sascha Hauer <s.ha...@pengutronix.de>
> > > 
> > > Sascha
> > 
> > Thanks.  So who picks this fix up?  Greg, is that you?
> 
> Yes, I will once 3.13-rc1 is out.

OK.  And send it to Linus for 3.13-rc2?  I know you've been traveling
and are busy, so I'm just pointing out it's a fix for 3.13.

josh
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to