On 2013-11-22 17:40, H Hartley Sweeten wrote:
Currently the COMEDI_DEBUG option enables the comedi_debug module parameter as
well as a DPRINTK() macro. To actually get debug messages to display the
kernel
still needs to be built with the -DDEBUG flag.
Cleanup all the custom uses of DEBUG in comedi and use the COMEDI_DEBUG option
to enable the ccflag -DDEBUG in the comedi subsystem.
Remove all uses of the DPRINTK macro and just use dev_dbg() or pr_debug()
instead.
Remove any debug messages that are just added noise.
Tidy up all the private debugging implementations in the comedi drivers.
H Hartley Sweeten (39):
staging: comedi: das6402: remove DEBUG noise
staging: comedi: pcl816: remove DEBUG macro
staging: comedi: dt282x: remove DEBUG define
staging: comedi: dt282x: remove DEBUG define
staging: comedi: ni_pcidio: remove custom DPRINTK macro
staging: comedi: ni_pcidio: remove DEBUG and DEBUG_FLAGS defines
staging: comedi: ni_pcidio: remove DEBUG define
staging: comedi: dt3000: remove DEBUG define
staging: comedi: remove comedi_debug module parameter
staging: comedi: range: remove use of DPRINTK
staging: comedi: pcl816: remove use of DPRINTK
staging: comedi: amplc_pci224: remove use of DPRINTK
staging: comedi: amplc_pci230: remove use of DPRINTK
staging: comedi: dt2801: remove use of DPRINTK
staging: comedi: comedi_fops: remove use of DPRINTK
staging: comedi: ni_pcidio: remove DEBUG_FLAGS define and code
staging: comedi: ni_pcidio: remove debug_int()
staging: comedi: ni_pcidio: remove use of DPRINTK
staging: comedi: remove DPRINTK macro
staging: comedi: mite: remove MDPRINTK macro
staging: comedi: mite: remove DEBUG_MITE code
staging: comedi: cb_pcidas64: remove DEBUG_PRINT
staging: comedi: gsc_hpdi: remove DEBUG_PRINT
staging: comedi: ni_at_a2150: remove A2150_DEBUG
staging: comedi: cb_pcimdas: remove CBPCIMDAS_DEBUG
staging: comedi: ni_pcimio: remove PCI_DEBUG
staging: comedi: pcmmio: remove DAMMIT_ITS_BROKEN debug
staging: comedi: pcmmio: remove commented out debug code
staging: comedi: dyna_pci10xx: convert a KERN_DEBUG message to dev_dbg()
staging: comedi: pcmmio: convert a KERN_DEBUG message to dev_dbg()
staging: comedi: c6xdigio: remove unnecessary c6xdigio_pwmo_insn_read()
staging: comedi: dt2814: remove disabled irq probe code
staging: comedi: pcl818: remove an unnecessary printk(KERN_DEBUG ...
staging: comedi: dmm32at: remove some unnecessary printk(KERN_DEBUG ...
staging: comedi: ni_mio_common: remove unused NI_CS5529_DEBUG code
staging: comedi: ni_mio_common: remove DEBUG_DIO messages
staging: comedi: ni_mio_common: remove DEBUG_STATUS_B messages
staging: comedi: ni_mio_common: remove DEBUG_STATUS_A messages
staging: comedi: ni_mio_common: remove DEBUG_INTERRUPT messages
drivers/staging/comedi/Makefile | 2 +
drivers/staging/comedi/comedi_fops.c | 133 +++++++++++----------
drivers/staging/comedi/comedidev.h | 11 --
drivers/staging/comedi/drivers/Makefile | 1 +
drivers/staging/comedi/drivers/amplc_pci224.c | 14 +--
drivers/staging/comedi/drivers/amplc_pci230.c | 52 ++++----
drivers/staging/comedi/drivers/c6xdigio.c | 9 --
drivers/staging/comedi/drivers/cb_pcidas64.c | 126 +-------------------
drivers/staging/comedi/drivers/cb_pcimdas.c | 3 -
drivers/staging/comedi/drivers/das6402.c | 9 --
drivers/staging/comedi/drivers/dmm32at.c | 6 -
drivers/staging/comedi/drivers/dt2801.c | 9 --
drivers/staging/comedi/drivers/dt2814.c | 26 ----
drivers/staging/comedi/drivers/dt282x.c | 10 --
drivers/staging/comedi/drivers/dt3000.c | 23 ----
drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +-
drivers/staging/comedi/drivers/fl512.c | 2 -
drivers/staging/comedi/drivers/gsc_hpdi.c | 78 ------------
drivers/staging/comedi/drivers/mite.c | 143 ----------------------
drivers/staging/comedi/drivers/mite.h | 12 --
drivers/staging/comedi/drivers/ni_65xx.c | 3 -
drivers/staging/comedi/drivers/ni_at_a2150.c | 25 ----
drivers/staging/comedi/drivers/ni_atmio.c | 15 ---
drivers/staging/comedi/drivers/ni_mio_common.c | 157+------------------------
drivers/staging/comedi/drivers/ni_mio_cs.c | 2 -
drivers/staging/comedi/drivers/ni_pcidio.c | 137 +--------------------
drivers/staging/comedi/drivers/ni_pcimio.c | 2 -
drivers/staging/comedi/drivers/pcl816.c | 46 +-------
drivers/staging/comedi/drivers/pcl818.c | 2 -
drivers/staging/comedi/drivers/pcmmio.c | 35 +-----
drivers/staging/comedi/kcomedilib/Makefile | 2 +
drivers/staging/comedi/range.c | 9 +-
32 files changed, 130 insertions(+), 977 deletions(-)
I suppose it was a bit of a mess!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
