[PATCH 12/48] staging: comedi: aio_aio12_8: use comedi_timeout()

[H Hartley Sweeten]

Use comedi_timeout() to wait for the analog input end-of-conversion.

Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com>
Cc: Ian Abbott <abbo...@mev.co.uk>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/staging/comedi/drivers/aio_aio12_8.c | 30 ++++++++++++++++++----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/comedi/drivers/aio_aio12_8.c 
b/drivers/staging/comedi/drivers/aio_aio12_8.c
index e2a9177..3f994ed 100644
--- a/drivers/staging/comedi/drivers/aio_aio12_8.c
+++ b/drivers/staging/comedi/drivers/aio_aio12_8.c
@@ -101,14 +101,27 @@ struct aio12_8_private {
        unsigned int ao_readback[4];
 };
 
+static int aio_aio12_8_ai_eoc(struct comedi_device *dev,
+                             struct comedi_subdevice *s,
+                             struct comedi_insn *insn,
+                             unsigned long context)
+{
+       unsigned int status;
+
+       status = inb(dev->iobase + AIO12_8_STATUS_REG);
+       if (status & AIO12_8_STATUS_ADC_EOC)
+               return 0;
+       return -EBUSY;
+}
+
 static int aio_aio12_8_ai_read(struct comedi_device *dev,
                               struct comedi_subdevice *s,
                               struct comedi_insn *insn, unsigned int *data)
 {
        unsigned int chan = CR_CHAN(insn->chanspec);
        unsigned int range = CR_RANGE(insn->chanspec);
-       unsigned int val;
        unsigned char control;
+       int ret;
        int n;
 
        /*
@@ -122,20 +135,15 @@ static int aio_aio12_8_ai_read(struct comedi_device *dev,
        inb(dev->iobase + AIO12_8_STATUS_REG);
 
        for (n = 0; n < insn->n; n++) {
-               int timeout = 5;
-
                /*  Setup and start conversion */
                outb(control, dev->iobase + AIO12_8_ADC_REG);
 
                /*  Wait for conversion to complete */
-               do {
-                       val = inb(dev->iobase + AIO12_8_STATUS_REG);
-                       timeout--;
-                       if (timeout == 0) {
-                               dev_err(dev->class_dev, "ADC timeout\n");
-                               return -ETIMEDOUT;
-                       }
-               } while (!(val & AIO12_8_STATUS_ADC_EOC));
+               ret = comedi_timeout(dev, s, insn, aio_aio12_8_ai_eoc, 0);
+               if (ret) {
+                       dev_err(dev->class_dev, "ADC timeout\n");
+                       return ret;
+               }
 
                data[n] = inw(dev->iobase + AIO12_8_ADC_REG) & s->maxdata;
        }
-- 
1.8.5.2

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel