On Thu, Feb 27, 2014 at 11:54:23PM +0000, Russell King - ARM Linux wrote:
> On Thu, Feb 27, 2014 at 02:52:34PM -0800, Greg KH wrote:
> > 
> > How can dmfc ever be NULL?  You control what values you pass to it, why
> > check it again?
> 
> Indeed.  This is actually a case where the static checker warning is
> ambiguous.  What's triggered it is the dmfc test for NULL after it's
> been used.  It doesn't necessarily mean that the test should be moved
> earlier.
> 

Btw, this is another case where Smatch wouldn't have generated a warning
if I had had the cross function database set up.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to