On Fri, Mar 21, 2014 at 03:52:23PM +0200, Matei Oprea wrote: > Fix different address spaces when unmapping IO. hi->addr_mapped[0] > and hi->addr_mapped[1] should be tagged __iomem. > > Signed-off-by: Matei Oprea <e...@opreamatei.ro> > Cc: ROSEdu Kernel Community <fire...@lists.rosedu.org> > --- > drivers/staging/cxt1e1/hwprobe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/cxt1e1/hwprobe.c > b/drivers/staging/cxt1e1/hwprobe.c > index 9b4198b..f55c27e 100644 > --- a/drivers/staging/cxt1e1/hwprobe.c > +++ b/drivers/staging/cxt1e1/hwprobe.c > @@ -174,12 +174,12 @@ cleanup_ioremap(void) > if (hi->pci_slot == 0xff) > break; > if (hi->addr_mapped[0]) { > - iounmap((void *)(hi->addr_mapped[0])); > + iounmap((void __iomem *)(hi->addr_mapped[0]));
While this may "fix" the sparse warning, it's far from ideal. Like I had suggested on IRC, a much better cleanup would be to make the addr_mapped member an array of __iomem-tagged pointers, and fixup the users. Josh _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel