On Thu, Apr 17, 2014 at 08:12:17AM -0400, Marcos A. Di Pietro wrote:
> Fixes code style errors in drivers/staging/bcm/Qos.c

Looks good, it applies fine, thanks.  :)  More comments at the bottom.

> 
> Signed-off-by: Marcos A. Di Pietro <marcos...@gmail.com>
> ---
>  drivers/staging/bcm/Qos.c | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
> index 4f31583..1f5edef 100644
> --- a/drivers/staging/bcm/Qos.c
> +++ b/drivers/staging/bcm/Qos.c
> @@ -4,11 +4,18 @@ This file contains the routines related to Quality of 
> Service.
>  */
>  #include "headers.h"
>  
> -static void EThCSGetPktInfo(struct bcm_mini_adapter *Adapter, PVOID 
> pvEthPayload, struct bcm_eth_packet_info *pstEthCsPktInfo);
> -static bool EThCSClassifyPkt(struct bcm_mini_adapter *Adapter, struct 
> sk_buff* skb, struct bcm_eth_packet_info *pstEthCsPktInfo, struct 
> bcm_classifier_rule *pstClassifierRule, B_UINT8 EthCSCupport);
> -
> -static USHORT        IpVersion4(struct bcm_mini_adapter *Adapter, struct 
> iphdr *iphd,
> -                        struct bcm_classifier_rule *pstClassifierRule);
> +static void EThCSGetPktInfo(struct bcm_mini_adapter *Adapter,
> +                         PVOID pvEthPayload,
> +                         struct bcm_eth_packet_info *pstEthCsPktInfo);
> +
> +static bool EThCSClassifyPkt(struct bcm_mini_adapter *Adapter,
> +                          struct sk_buff *skb,
> +                          struct bcm_eth_packet_info *pstEthCsPktInfo,
> +                          struct bcm_classifier_rule *pstClassifierRule,
> +                          B_UINT8 EthCSCupport);
> +
> +static USHORT IpVersion4(struct bcm_mini_adapter *Adapter, struct iphdr 
> *iphd,
> +                      struct bcm_classifier_rule *pstClassifierRule);
>  
>  static VOID PruneQueue(struct bcm_mini_adapter *Adapter, INT iIndex);
>  
> -- 
> Fixes whitespace damage and aligns function parameters properly.

This is not the cut-off mark I meant.  I meant the --- cut off under
the signed off by line.  Between the --- and the diff is extra
information which won't be safed in the permanent git log.

But it doesn't matter.

regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to