In Step 1 of the (*do_cmdtest), the cmd->scan_begin_src is checked to
only allow TRIG_FOLLOW. The (*do_cmd) does not need to recheck this.

Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com>
Cc: Ian Abbott <abbo...@mev.co.uk>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/staging/comedi/drivers/adv_pci1710.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c 
b/drivers/staging/comedi/drivers/adv_pci1710.c
index 9ce0535..60b926e 100644
--- a/drivers/staging/comedi/drivers/adv_pci1710.c
+++ b/drivers/staging/comedi/drivers/adv_pci1710.c
@@ -1115,15 +1115,13 @@ static int pci171x_ai_cmd(struct comedi_device *dev, 
struct comedi_subdevice *s)
 {
        struct comedi_cmd *cmd = &s->async->cmd;
 
-       if (cmd->scan_begin_src == TRIG_FOLLOW) {       /*  mode 1, 2, 3 */
-               if (cmd->convert_src == TRIG_TIMER) {   /*  mode 1 and 2 */
-                       return pci171x_ai_docmd_and_mode(cmd->start_src ==
-                                                        TRIG_EXT ? 2 : 1, dev,
-                                                        s);
-               }
-               if (cmd->convert_src == TRIG_EXT) {     /*  mode 3 */
-                       return pci171x_ai_docmd_and_mode(3, dev, s);
-               }
+       if (cmd->convert_src == TRIG_TIMER) {   /*  mode 1 and 2 */
+               return pci171x_ai_docmd_and_mode(cmd->start_src ==
+                                                TRIG_EXT ? 2 : 1, dev,
+                                                s);
+       }
+       if (cmd->convert_src == TRIG_EXT) {     /*  mode 3 */
+               return pci171x_ai_docmd_and_mode(3, dev, s);
        }
 
        return -1;
-- 
1.9.2

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to