On Sat, Apr 26, 2014 at 10:13:55PM +0530, navin patidar wrote: > Use inline functions provided by USB subsystem to check endpoint type, > instead of macros implemented by driver to do the same. > > Unnecessary debugging messages are also removed. >
I like both these changes but they would have been so much easier to review if you deleted the debugging messagese in [patch 1/2] and then changed the endpoint functions in [patch 2/2]. > @@ -183,60 +143,36 @@ static struct dvobj_priv *usb_dvobj_init(struct > usb_interface *usb_intf) > pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints; > > for (i = 0; i < pdvobjpriv->nr_endpoint; i++) { > + Don't put a blank line here, btw. > + int ep_num; > phost_endp = phost_iface->endpoint + i; Anyway, please resend because it needs to be broken into two patches. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel