On Sun, Apr 27, 2014 at 01:06:58PM -0400, Oleg Drokin wrote: > int > +cfs_cpt_table_print(struct cfs_cpt_table *cptab, char *buf, int len) > +{ > + int rc = 0;
GCC has a feature where it warns about unitialized variables. If you do bogus it disables this safety feature. Also the bogus assignment is confusing for people trying to read the code. > + > + rc = snprintf(buf, len, "%d\t: %d\n", 0, 0); > + len -= rc; > + if (len <= 0) > + return -EFBIG; It would be more clear to say: rc = snprintf(buf, len, "%d\t: %d\n", 0, 0); if (rc >= len) return -EFBIG; return rc; regards, dan carpenter > + > + return rc; > +} > +EXPORT_SYMBOL(cfs_cpt_table_print); > + _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel